-
Notifications
You must be signed in to change notification settings - Fork 816
[release/3.0] Update dependencies from dotnet/arcade #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dougbu
merged 2 commits into
release/3.0
from
darc-release/3.0-773aa98b-b331-4620-82d7-19f9965db1a5
Sep 26, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,13 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.--> | ||
| <add key="darc-pub-dotnet-core-setup-7d57652" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-core-setup-7d57652f/nuget/v3/index.json" /> | ||
| <add key="darc-pub-dotnet-corefx-4ac4c03" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-corefx-4ac4c036/nuget/v3/index.json" /> | ||
| <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.--> | ||
| <clear /> | ||
| <add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" /> | ||
| <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" /> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> | ||
| </packageSources> | ||
| </configuration> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| param( | ||
| [string] $token | ||
| ) | ||
|
|
||
| Write-Host "##vso[task.setvariable variable=VSS_NUGET_ACCESSTOKEN]$token" | ||
| Write-Host "##vso[task.setvariable variable=VSS_NUGET_URI_PREFIXES]https://dnceng.pkgs.visualstudio.com/;https://pkgs.dev.azure.com/dnceng/;https://devdiv.pkgs.visualstudio.com/;https://pkgs.dev.azure.com/devdiv/" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
eng/common/templates/post-build/channels/netcore-3-tools-validation.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| parameters: | ||
| artifactsPublishingAdditionalParameters: '' | ||
| publishInstallersAndChecksums: false | ||
|
|
||
| stages: | ||
| - stage: NetCore_3_Tools_Validation_Publish | ||
| dependsOn: validate | ||
| variables: | ||
| - template: ../common-variables.yml | ||
| displayName: .NET 3 Tools - Validation Publishing | ||
| jobs: | ||
| - template: ../setup-maestro-vars.yml | ||
|
|
||
| - job: publish_assets | ||
| displayName: Publish Assets | ||
| dependsOn: setupMaestroVars | ||
| variables: | ||
| - group: DotNet-Blob-Feed | ||
| - group: AzureDevOps-Artifact-Feeds-Pats | ||
| - name: BARBuildId | ||
| value: $[ dependencies.setupMaestroVars.outputs['setReleaseVars.BARBuildId'] ] | ||
| - name: IsStableBuild | ||
| value: $[ dependencies.setupMaestroVars.outputs['setReleaseVars.IsStableBuild'] ] | ||
| condition: contains(dependencies.setupMaestroVars.outputs['setReleaseVars.InitialChannels'], format('[{0}]', variables.NETCore_3_Tools_Validation_Channel_Id)) | ||
| pool: | ||
| vmImage: 'windows-2019' | ||
| steps: | ||
| - task: DownloadBuildArtifacts@0 | ||
| displayName: Download Package Artifacts | ||
| inputs: | ||
| buildType: current | ||
| artifactName: PackageArtifacts | ||
|
|
||
| - task: DownloadBuildArtifacts@0 | ||
| displayName: Download Blob Artifacts | ||
| inputs: | ||
| buildType: current | ||
| artifactName: BlobArtifacts | ||
|
|
||
| - task: DownloadBuildArtifacts@0 | ||
| displayName: Download Asset Manifests | ||
| inputs: | ||
| buildType: current | ||
| artifactName: AssetManifests | ||
|
|
||
| - task: NuGetToolInstaller@1 | ||
| displayName: 'Install NuGet.exe' | ||
|
|
||
| # This is necessary whenever we want to publish/restore to an AzDO private feed | ||
| - task: NuGetAuthenticate@0 | ||
| displayName: 'Authenticate to AzDO Feeds' | ||
|
|
||
| - task: PowerShell@2 | ||
| displayName: Enable cross-org publishing | ||
| inputs: | ||
| filePath: eng\common\enable-cross-org-publishing.ps1 | ||
| arguments: -token $(dn-bot-dnceng-artifact-feeds-rw) | ||
|
|
||
| - task: PowerShell@2 | ||
| displayName: Publish Assets | ||
| inputs: | ||
| filePath: eng\common\sdk-task.ps1 | ||
| arguments: -task PublishArtifactsInManifest -restore -msbuildEngine dotnet | ||
| /p:ArtifactsCategory=$(_DotNetValidationArtifactsCategory) | ||
| /p:IsStableBuild=$(IsStableBuild) | ||
| /p:IsInternalBuild=$(IsInternalBuild) | ||
| /p:RepositoryName=$(Build.Repository.Name) | ||
| /p:CommitSha=$(Build.SourceVersion) | ||
| /p:NugetPath=$(NuGetExeToolPath) | ||
| /p:AzdoTargetFeedPAT='$(dn-bot-dnceng-universal-packages-rw)' | ||
| /p:AzureStorageTargetFeedPAT='$(dotnetfeed-storage-access-key-1)' | ||
| /p:BARBuildId=$(BARBuildId) | ||
| /p:MaestroApiEndpoint='$(MaestroApiEndPoint)' | ||
| /p:BuildAssetRegistryToken='$(MaestroApiAccessToken)' | ||
| /p:ManifestsBasePath='$(Build.ArtifactStagingDirectory)/AssetManifests/' | ||
| /p:BlobBasePath='$(Build.ArtifactStagingDirectory)/BlobArtifacts/' | ||
| /p:PackageBasePath='$(Build.ArtifactStagingDirectory)/PackageArtifacts/' | ||
| /p:Configuration=Release | ||
| /p:PublishInstallersAndChecksums=${{ parameters.publishInstallersAndChecksums }} | ||
| /p:InstallersTargetStaticFeed=$(InstallersBlobFeedUrl) | ||
| /p:InstallersAzureAccountKey=$(dotnetcli-storage-key) | ||
| /p:ChecksumsTargetStaticFeed=$(ChecksumsBlobFeedUrl) | ||
| /p:ChecksumsAzureAccountKey=$(dotnetclichecksums-storage-key) | ||
| /p:PublishToAzureDevOpsNuGetFeeds=true | ||
| /p:AzureDevOpsStaticShippingFeed='https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json' | ||
| /p:AzureDevOpsStaticShippingFeedKey='$(dn-bot-dnceng-artifact-feeds-rw)' | ||
| /p:AzureDevOpsStaticTransportFeed='https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json' | ||
| /p:AzureDevOpsStaticTransportFeedKey='$(dn-bot-dnceng-artifact-feeds-rw)' | ||
| /p:AzureDevOpsStaticSymbolsFeed='https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools-symbols/nuget/v3/index.json' | ||
| /p:AzureDevOpsStaticSymbolsFeedKey='$(dn-bot-dnceng-artifact-feeds-rw)' | ||
| ${{ parameters.artifactsPublishingAdditionalParameters }} | ||
|
|
||
| - template: ../../steps/promote-build.yml | ||
| parameters: | ||
| ChannelId: ${{ variables.NETCore_3_Tools_Validation_Channel_Id }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmitche I'm a bit surprised this PR validated properly given I've seen mention of moving the
<clear />arround being a bug. Did this update succeed only because Extensions has already moved on from GA packages?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because all the packages (stable) that were in those feeds have been published to nuget.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the dependency update code smart enough to move the
<clear />back up when it next changes the feeds in the comments?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes