Skip to content

[release/3.0] Update dependencies from dotnet/arcade #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190924.3
  • Date Produced: 9/24/2019 6:16 PM
  • Commit: 0e9ffd6464aff37aef2dc41dc2162d258f266e32
  • Branch: refs/heads/release/3.x
  • Updates:
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19474.3
    • Microsoft.DotNet.GenAPI -> 1.0.0-beta.19474.3
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19474.3

…924.3

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19474.3
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19474.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19474.3
@dotnet-maestro dotnet-maestro bot requested review from dougbu and a team as code owners September 25, 2019 16:22
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: Extensions-ci, Extensions-ci (Build Test: Linux Source Build), Extensions-ci (Build OSX Release), Extensions-ci (Build Ubuntu 16.04 Release), Extensions-ci (Build OSX Debug), Extensions-ci (Build Ubuntu 16.04 Debug), Extensions-ci (Build Windows Release), Extensions-ci (Build Windows Debug), Extensions-ci (Build Code check)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 25, 2019

Same as dotnet/blazor#1899

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: Extensions-ci, Extensions-ci (Build Test: Linux Source Build), Extensions-ci (Build OSX Release), Extensions-ci (Build Ubuntu 16.04 Release), Extensions-ci (Build OSX Debug), Extensions-ci (Build Ubuntu 16.04 Debug), Extensions-ci (Build Windows Release), Extensions-ci (Build Windows Debug), Extensions-ci (Build Code check)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

<!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
<add key="darc-pub-dotnet-core-setup-7d57652" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-core-setup-7d57652f/nuget/v3/index.json" />
<add key="darc-pub-dotnet-corefx-4ac4c03" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-corefx-4ac4c036/nuget/v3/index.json" />
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
<clear />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche I'm a bit surprised this PR validated properly given I've seen mention of moving the <clear /> arround being a bug. Did this update succeed only because Extensions has already moved on from GA packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because all the packages (stable) that were in those feeds have been published to nuget.org.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the dependency update code smart enough to move the <clear /> back up when it next changes the feeds in the comments?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@dougbu dougbu merged commit 6f84a4a into release/3.0 Sep 26, 2019
@ghost ghost deleted the darc-release/3.0-773aa98b-b331-4620-82d7-19f9965db1a5 branch September 26, 2019 01:42
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants