Skip to content

[release/11.0] Fix Cosmos concurrency tests by normalizing ETag comparisons #39215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 3 commits into from
Oct 12, 2026
Merged

[release/11.0] Fix Cosmos concurrency tests by normalizing ETag comparisons #39215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68d41de
Normalize Cosmos concurrency ETags
Copilot Oct 9, 2026
669aae5
Normalize all Cosmos ETag assertions
Copilot Oct 9, 2026
4b608fc
Keep ETag NotEmpty assertions unchanged
Copilot Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/EFCore.Cosmos.FunctionalTests/CosmosConcurrencyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,26 +95,26 @@ public async Task Etag_is_updated_in_entity_after_SaveChanges(bool? contentRespo
var customerFromStore = await context.Set<Customer>().SingleAsync();

Assert.NotEmpty(customerFromStore.ETag);
Assert.Equal(etag, customerFromStore.ETag);
Assert.Equal(etag.Trim('"'), customerFromStore.ETag.Trim('"'));

customerFromStore.Children.Add(new DummyChild { Id = "1" });

await context.SaveChangesAsync();

Assert.NotEmpty(customerFromStore.ETag);
Assert.NotEqual(etag, customerFromStore.ETag);
Assert.NotEqual(etag.Trim('"'), customerFromStore.ETag.Trim('"'));

customerFromStore.Children.Add(new DummyChild { Id = "2" });

Assert.NotEmpty(customerFromStore.ETag);
Assert.NotEqual(etag, customerFromStore.ETag);
Assert.NotEqual(etag.Trim('"'), customerFromStore.ETag.Trim('"'));

customerFromStore.Children.Add(new DummyChild { Id = "3" });

await context.SaveChangesAsync();

Assert.NotEmpty(customerFromStore.ETag);
Assert.NotEqual(etag, customerFromStore.ETag);
Assert.NotEqual(etag.Trim('"'), customerFromStore.ETag.Trim('"'));
}
}

Expand Down Expand Up @@ -161,26 +161,26 @@ public async Task Etag_is_updated_in_derived_entity_after_SaveChanges(bool? cont
var customerFromStore = await context.Set<PremiumCustomer>().SingleAsync();

Assert.NotEmpty(customerFromStore.ETag);
Assert.Equal(etag, customerFromStore.ETag);
Assert.Equal(etag.Trim('"'), customerFromStore.ETag.Trim('"'));

customerFromStore.Children.Add(new DummyChild { Id = "1" });

await context.SaveChangesAsync();

Assert.NotEmpty(customerFromStore.ETag);
Assert.NotEqual(etag, customerFromStore.ETag);
Assert.NotEqual(etag.Trim('"'), customerFromStore.ETag.Trim('"'));

customerFromStore.Children.Add(new DummyChild { Id = "2" });

Assert.NotEmpty(customerFromStore.ETag);
Assert.NotEqual(etag, customerFromStore.ETag);
Assert.NotEqual(etag.Trim('"'), customerFromStore.ETag.Trim('"'));

customerFromStore.Children.Add(new DummyChild { Id = "3" });

await context.SaveChangesAsync();

Assert.NotEmpty(customerFromStore.ETag);
Assert.NotEqual(etag, customerFromStore.ETag);
Assert.NotEqual(etag.Trim('"'), customerFromStore.ETag.Trim('"'));
}
}

Expand Down
Loading