Repository navigation
[release/11.0] Fix Cosmos concurrency tests by normalizing ETag comparisons - #39215
Open
AndriySvyryd with Copilot wants to merge 3 commits into
Open
AndriySvyryd with Copilot wants to merge 3 commits into
AndriySvyryd with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
October 9, 2026 20:08
View session
AndriySvyryd
marked this pull request as ready for review
October 9, 2026 20:09
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
0 open findings
What changed in this PR
Normalizes Cosmos ETag comparisons so quoted and unquoted equivalent values compare consistently.
Changes:
- Trims surrounding quotes in ETag equality and inequality assertions.
- Preserves original ETag values for
Assert.NotEmptychecks.
| File | Description |
|---|---|
test/EFCore.Cosmos.FunctionalTests/CosmosConcurrencyTest.cs |
Normalizes ETag comparisons in concurrency tests. |
🧠 Review effort: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Code Coverage OverviewLanguages: C# C# / code-coverageThe overall line coverage in commit 4b608fc in the Show a line coverage summary of the most impacted files.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmos concurrency tests can receive ETags in quoted or unquoted formats depending on emulator version, causing equivalent values to fail string comparisons.
Assert.NotEmptychecks against the original ETag values.