(RC2) Fix ESCAPE clause for Azure Synapse. (#34463) #34508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cincuranet can you please fill out the template and ping @artl93 as this is for RC2? |
|
I was looking for a template, but I don't see any in https://github.com/dotnet/efcore/tree/main/.github. Should I use https://github.com/dotnet/runtime/blob/main/.github/PULL_REQUEST_TEMPLATE/servicing_pull_request_template.md? |
|
You can copy-paste on from one of the PRs that have already been merged to release/9.0, e.g. #34495. |
cincuranet
changed the title
|
Done. @artl93 was already added as reviewer. |
|
Closing in favor of #34509. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #34463
Fixes #33555
Description
Fixes translation of
Contains/StartsWith/EndsWithinto SQL on Azure Synapse.Customer impact
Customers using Azure Synapse are unable to run queries using
Contains/StartsWith/EndsWithbecause improper SQL is generated.How found
Reported by customer.
Regression
Yes.
Testing
Tests added.
Risk
Low.