(RC2) Cosmos: strip implicit casts to allow vector search over arrays #34495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
changed the title
|
/cc @artl93 |
roji
approved these changes
Aug 21, 2024
Fixes #34402 Co-authored-by: Arthur Vickers <ajcvickers@hotmail.com>
ajcvickers
force-pushed
the
CheeseAndOnionCrisps
branch
from
c308af5
to
415b062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #34437
Fixes #34402
Description
Cosmos vector search was merged as an experimental feature in EF9. This PR adds support of array types in addition to
ReadOnlyMemory<>types.Customer impact
Allow customers to use vector search with array properties.
How found
Known bug on vector search implementation.
Regression
No.
Testing
Tests added and run using the preview SDK.
Risk
Low.