Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Tools: Warn/error when using new features on old runtimes #26127

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Sep 21, 2021

Fixes #25153

Customer impact

Without this, users will get this lovely error if they try to run dotnet ef dbcontext optimize on projects using EF Core 5.0 and 3.1:

Could not load type 'Microsoft.EntityFrameworkCore.Design.OperationExecutor+OptimizeContext' from assembly 'Microsoft.EntityFrameworkCore.Design, Version=5.0.10.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.

Regression

No--feature is new in 6.0.

Testing

Manually verified. We don't have any automated tests mixing EF Core 5.0 projects and 6.0 tools.

Risk

Low.

@bricelam bricelam requested review from Pilchie and a team September 21, 2021 21:16
@bricelam
Copy link
Contributor Author

@Pilchie

@Pilchie
Copy link
Member

Pilchie commented Sep 22, 2021

Approved for EF Core 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when using a newer version of dotnet ef with old runtime (command specific)
3 participants