Tools: Warn/error when using new features on old runtimes

Fixes #25153
dotnet · Sep 23, 2021 · e94739a · e94739a
1 parent 5e382f1
commit e94739a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 0 deletions.
diff --git a/src/ef/Commands/DbContextOptimizeCommand.cs b/src/ef/Commands/DbContextOptimizeCommand.cs
@@ -1,13 +1,21 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using Microsoft.EntityFrameworkCore.Internal;
+using Microsoft.EntityFrameworkCore.Tools.Properties;
+
 namespace Microsoft.EntityFrameworkCore.Tools.Commands
 {
     // ReSharper disable once ArrangeTypeModifiers
     internal partial class DbContextOptimizeCommand
     {
         protected override int Execute(string[] args)
         {
+            if (new SemanticVersionComparer().Compare(EFCoreVersion, "6.0.0") < 0)
+            {
+                throw new CommandException(Resources.VersionRequired("6.0.0"));
+            }
+
             using var executor = CreateExecutor(args);
             executor.OptimizeContext(
                 _outputDir!.Value(),

diff --git a/src/ef/Commands/MigrationsListCommand.cs b/src/ef/Commands/MigrationsListCommand.cs
@@ -60,19 +60,25 @@ private static void ReportJsonResults(IReadOnlyList<IDictionary> migrations)
 
         private static void ReportResults(IEnumerable<IDictionary> migrations)
         {
+            var anyUnknown = false;
             var any = false;
             foreach (var migration in migrations)
             {
                 var id = migration["Id"] as string;
                 var applied = migration["Applied"] as bool?;
                 Reporter.WriteData($"{id}{(applied != false ? null : Resources.Pending)}");
+                anyUnknown |= !applied.HasValue;
                 any = true;
             }
 
             if (!any)
             {
                 Reporter.WriteInformation(Resources.NoMigrations);
             }
+            else if (anyUnknown)
+            {
+                Reporter.WriteWarning(Resources.PendingUnknown);
+            }
         }
     }
 }
diff --git a/src/ef/Properties/Resources.Designer.cs b/src/ef/Properties/Resources.Designer.cs
diff --git a/src/ef/Properties/Resources.resx b/src/ef/Properties/Resources.resx
@@ -321,6 +321,9 @@
   <data name="Pending" xml:space="preserve">
     <value> (Pending)</value>
   </data>
+  <data name="PendingUnknown" xml:space="preserve">
+    <value>Pending status not shown. Unable to determine which migrations have been applied. This can happen when your project uses a version of Entity Framework Core lower than 5.0.0 or when an error occurrs while accessing the database.</value>
+  </data>
   <data name="PrefixDescription" xml:space="preserve">
     <value>Prefix output with level.</value>
   </data>