Skip to content

[main] Update dependencies from dotnet/runtime #25092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 14, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: daf314a8-d8c8-4b54-8dcc-08d82e674dfc
  • Build: 20210614.1
  • Date Produced: 6/14/2021 9:52 AM
  • Commit: af5c238556e204583b129cc8f5c7338f84dc2c40
  • Branch: refs/heads/main

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@bricelam bricelam self-assigned this Jun 14, 2021
@bricelam bricelam force-pushed the darc-main-c7b661af-51c8-41e2-a4fd-97e35fece8e5 branch from 42f0ef3 to 9067ee7 Compare June 14, 2021 16:42
@bricelam
Copy link
Contributor

/cc @davidfowl (This will update Microsoft.Extensions.HostFactoryResolver.Sources.)

@bricelam bricelam force-pushed the darc-main-c7b661af-51c8-41e2-a4fd-97e35fece8e5 branch from 9067ee7 to 5e478b9 Compare June 14, 2021 17:25
…0614.1

Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , System.Collections.Immutable , System.Diagnostics.DiagnosticSource
 From Version 6.0.0-preview.6.21276.2 -> To Version 6.0.0-preview.6.21314.1
@bricelam bricelam force-pushed the darc-main-c7b661af-51c8-41e2-a4fd-97e35fece8e5 branch from 5e478b9 to 36dd65c Compare June 14, 2021 17:29
@dotnet-maestro dotnet-maestro bot merged commit a98be47 into main Jun 14, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-c7b661af-51c8-41e2-a4fd-97e35fece8e5 branch June 14, 2021 18:01
@@ -27,6 +26,12 @@ protected override Assembly TargetAssembly
public class DesignApiConsistencyFixture : ApiConsistencyFixtureBase
{
public override HashSet<Type> FluentApiTypes { get; } = new() { typeof(DesignTimeServiceCollectionExtensions) };

public override HashSet<Type> NonSealedPrivateNestedTypes { get; } = new()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix this

@@ -1,49 +1,51 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.Extensions.Caching.Memory" Version="6.0.0-preview.6.21276.2">
<!-- NB: Pinned for compatibility with Preview 4 -->
<Dependency Name="Microsoft.Extensions.Caching.Memory" Version="6.0.0-preview.6.21276.2" Pinned="True">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bricelam Are you planning to unpin this prior to shipping? This will create an incoherent build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pilchie Can you get someone to take a look at this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #25148 so it doesn't get forgotten. Also tagging @AndriySvyryd here.

Copy link
Contributor

@bricelam bricelam Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can unpin it in the preview6 branch then unpin in main once preview 6 ships

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants