Skip to content

Conversation

@JimDaly
Copy link
Contributor

@JimDaly JimDaly commented Apr 18, 2022

@stephentoub

Per comments in #7941 , removing remarks that say 'This type and its' members are intended for compiler use...

At this point, the right thing for TaskAwaiter and TaskAwaiter<T> is probably to just strike those sentence from the docs, though some extra verbiage around the distinction from Task.Wait would be welcome

See also related PR #7968

@stephentoub 

Per comments in dotnet#7941 , removing remarks that say 'This type and its' members are intended for compiler use...

> At this point, the right thing for TaskAwaiter and TaskAwaiter<T> is probably to just strike those sentence from the docs, though some extra verbiage around the distinction from Task.Wait would be welcome
@JimDaly JimDaly requested a review from a team as a code owner April 18, 2022 17:09
@dnfadmin
Copy link

dnfadmin commented Apr 18, 2022

CLA assistant check
All CLA requirements met.

@opbld31
Copy link

opbld31 commented Apr 18, 2022

Docs Build status updates of commit 34a770f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/TaskAwaiter.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@JimDaly
Copy link
Contributor Author

JimDaly commented Apr 18, 2022

@gewarren
Seems like the changes I've applied to remove the remarks haven't removed the text 'This API supports the product infrastructure and is not intended to be used directly from your code.' which is still found in the preview: https://review.docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.taskawaiter
Not clear how that would be removed. Can you help?

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update TaskAwaiter<T> as well?

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Apr 19, 2022

Docs Build status updates of commit fd038a8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/TaskAwaiter.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are you planning to update TaskAwaiter<T> as well?

@opbld30
Copy link

opbld30 commented Apr 19, 2022

Docs Build status updates of commit 268b9dd:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/TaskAwaiter.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@JimDaly
Copy link
Contributor Author

JimDaly commented Apr 19, 2022

This looks good to me. Are you planning to update TaskAwaiter<T> as well?

Yes, I did in a separate PR

@opbld34
Copy link

opbld34 commented Apr 19, 2022

Docs Build status updates of commit ce74628:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/TaskAwaiter.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor

Closing in favor of #7968.

@gewarren gewarren closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants