Skip to content

Conversation

@JimDaly
Copy link
Contributor

@JimDaly JimDaly commented Apr 18, 2022

@stephentoub

Per comments in #7941 , removing remarks that say 'This method is intended for compiler use rather than for use in application code.'

At this point, the right thing for TaskAwaiter and TaskAwaiter is probably to just strike those sentence from the docs, though some extra verbiage around the distinction from Task.Wait would be welcome

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@stephentoub 

Per comments in dotnet#7941 , removing remarks that say 'This method is intended for compiler use rather than for use in application code.'

> At this point, the right thing for TaskAwaiter and TaskAwaiter<T> is probably to just strike those sentence from the docs, though some extra verbiage around the distinction from Task.Wait would be welcome
@JimDaly JimDaly requested a review from kouvel as a code owner April 18, 2022 17:08
@ghost
Copy link

ghost commented Apr 18, 2022

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

@stephentoub

Per comments in #7941 , removing remarks that say 'This method is intended for compiler use rather than for use in application code.'

At this point, the right thing for TaskAwaiter and TaskAwaiter is probably to just strike those sentence from the docs, though some extra verbiage around the distinction from Task.Wait would be welcome

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Author: JimDaly
Assignees: -
Labels:

area-System.Threading.Tasks

Milestone: -

@JimDaly JimDaly mentioned this pull request Apr 18, 2022
@opbld33

This comment was marked as outdated.

JimDaly and others added 6 commits April 19, 2022 11:25
@stephentoub 

Per comments in dotnet#7941 , removing remarks that say 'This type and its' members are intended for compiler use...

> At this point, the right thing for TaskAwaiter and TaskAwaiter<T> is probably to just strike those sentence from the docs, though some extra verbiage around the distinction from Task.Wait would be welcome
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@JimDaly JimDaly requested a review from a team as a code owner April 19, 2022 18:28
This was referenced Apr 19, 2022
@opbld32
Copy link

opbld32 commented Apr 19, 2022

Docs Build status updates of commit e25bb92:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/TaskAwaiter.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/TaskAwaiter`1.xml ✅Succeeded View
xml/System.Threading.Tasks/Task.xml ✅Succeeded View
xml/System.Threading.Tasks/Task`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants