Added sample code to read attributes for C# tour #6488
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
requested changes
Jul 17, 2018
There was a problem hiding this comment.
Once again, thanks @sputier This is a great addition.
The only change I would make is to update the snippet reference to use a named snippet rather than line numbers.
|
|
||
| The following code sample demonstrates how to get the `HelpAttribute` instances associated to the `Widget` class and its `Display` method. | ||
|
|
||
| [!code-csharp[AttributeRead](../../../samples/snippets/csharp/tour/attributes/Program.cs#L34-L54)] |
There was a problem hiding this comment.
Rather than the line numbers, let's use a snippet reference:
[!code-csharpAttributeRead]
(If you name the snippet as I did in the samples PR)
|
I made the requested change 😄 |
|
closing and reopening to force a build now that the samples PR is merged. |
BillWagner
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a snippet to demonstrate how to read attributes with C# at C# Attributes - A tour of the C# language
Fixes #5424
Related PR in dotnet/samples : dotnet/samples#186