Added sample code to read attributes for C# tour #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
requested changes
Jul 17, 2018
There was a problem hiding this comment.
I really like this sample @sputier It will add to the understanding of the topic.
We try to avoid Line numbers in includes because they are very brittle. Can you update this PR, and the associated docs PR, with the snippet I've recommended.
Thanks again for contributing to docs.
| { | ||
| public static void Main(string[] args) | ||
| { | ||
| Type widgetType = typeof(Widget); |
There was a problem hiding this comment.
Let's add a marker here (and at the end) rather than using line numbers. Line numbers are very brittle in the OPS build. For example:
// <SnippetReadAttributes>| Console.WriteLine($"Display method help URL : {attr.Url} - Related topic : {attr.Topic}"); | ||
| } | ||
|
|
||
| Console.ReadLine(); |
There was a problem hiding this comment.
And then, after this line, close the snippet:
// </SnippetReadAttributes>
BillWagner
approved these changes
Jul 17, 2018
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
* Added sample code to read attributes for C# tour * Replaced line numbers in samples with // <SnippetReadAttributes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a snippet to demonstrate how to read attributes with C# at C# Attributes - A tour of the C# language
Fixes dotnet/docs#5424