update readonly with new usages in new C# versions.
#6086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
added
the
🚧 Hold for related PR
|
closing and reopening to force a build. |
|
yet another build. |
BillWagner
removed
the
🚧 Hold for related PR
JRAlexander
suggested changes
Jul 2, 2018
|
|
||
| [!code-csharp[readonly struct example](~/samples/snippets/csharp/keywords/ReadonlyKeywordExamples.cs#ReadonlyStruct)] | ||
|
|
||
| The preceding example uses readonly auto properties to declare its storage. That instructs the compiler to create `readonly` backing fields for those properties. You could also declare `readonly` fields directly: |
There was a problem hiding this comment.
Should there be a link to readonly auto properties?
| public readonly int y = 5; | ||
| ``` | ||
|
|
||
| - For an instance field, in the instance constructors of the class that contains the field declaration, or for a static field, in the static constructor of the class that contains the field declaration. These are also the only contexts in which it is valid to pass a `readonly` field as an [out](out-parameter-modifier.md) or [ref](ref.md) parameter. |
There was a problem hiding this comment.
This first sentence is kind of awkward. I'm not sure what you are trying to say.
|
|
||
| ## Readonly struct example | ||
|
|
||
| The `readonly` modifier on a `struct` definition declares that the struct is **immutable**. Every instance field of the `struct` must be marked `readonly`, as shown in the following example: |
There was a problem hiding this comment.
Should immutable be surrounded by "`"?
There was a problem hiding this comment.
Nope, that's not a keyword.
|
Thanks @JRAlexander |
JRAlexander
approved these changes
Jul 2, 2018
|
LGTM. |
when ready!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5682
/cc @fitdev
Relies on dotnet/samples#133