Update samples for readonly keyword #133
Conversation
Move existing snippets from docs repo. Add samples for new uses of readonly.
There was a problem hiding this comment.
Left one very minor nit, @BillWagner, but otherwise LGTM. You can merge when you're ready.
| @@ -0,0 +1,89 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
There was a problem hiding this comment.
nit: this and the System.Text namespace aren't actually used in the example, so I'd remove them.
|
should we also remove the old ones that readonly would rely on once I got to that topic to make the switch to dotnet/samples? let me find where that would be. |
|
They are here: https://github.com/dotnet/samples/blob/master/snippets/csharp/VS_Snippets_VBCSharp/csrefKeywordsModifiers/CS/csrefKeywordsModifiers.cs I made as far as letter C on the keywords folder to remove the inline snippets 😄 |
|
@mairaw In dotnet/docs#6086 I removed the snippets from docs that were in this topic. I've been trying to remove any as I move them. We can start a separate task to remove other unused snippets in that repo, but that feels like a lower priority. |
|
No, no... what I meant is that the sample already existed here and now we have two of the same (or almost the same). |
Move existing snippets from docs repo. Add samples for new uses of readonly.
3 participants
Move existing snippets from docs repo.
Add samples for new uses of readonly.
For dotnet/docs#5682