Skip to content

fix method name #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Jun 20, 2018
Merged

fix method name #6049

merged 59 commits into from
Jun 20, 2018

Conversation

@imba-tjd
Copy link
Contributor

mairaw and others added 30 commits April 2, 2018 16:56
@mairaw
Merge pull request #4856 from dotnet/master
fb3f6a2 
Update live with current master
@mairaw
Merge pull request #4868 from dotnet/master
8848ae2 
Update live with current master
@mairaw
Merge pull request #4883 from dotnet/master
9094335 
Update live with current master
@mairaw
Merge pull request #4891 from dotnet/master
b750a8e 
Update live with current master
@mairaw
Merge pull request #4899 from dotnet/master
dc3c8a2 
Update Live with current Master
@mairaw
Merge pull request #4910 from dotnet/master
8b011de 
Update live with current master
@mairaw
Merge pull request #4924 from dotnet/master
acd77ef 
Update live with current master
@mairaw
Merge pull request #4938 from dotnet/master
864e834 
Update Live with current Master
@mairaw
Merge pull request #4943 from dotnet/master
9a4fe1a 
Update Live with current Master
@mairaw
Merge pull request #4949 from dotnet/master
7e52792 
Update live with current master
@mairaw
Merge pull request #4955 from dotnet/master
2e8acae 
Update live with current master
@mairaw
Merge pull request #4971 from dotnet/master
68b60d3 
Update live with current master
@BillWagner
Merge pull request #4981 from dotnet/master
6809156 
Update Live with current Master
@mairaw
Merge pull request #5010 from dotnet/master
7a99c2d 
Update live with current master
@mairaw
Merge pull request #5021 from dotnet/master
8c996b9 
Update live with current master
@mairaw
Merge pull request #5035 from dotnet/master
86adcc0 
Update Live with current Master
@mairaw
Merge pull request #5051 from dotnet/master
2042de7 
Update Live with current Master
@mairaw
Merge pull request #5061 from dotnet/master
03ee570 
Update live with current master
Merge pull request #5084 from dotnet/master
94d33ca 
Update Live with current Master
Merge pull request #5087 from dotnet/master
cb70f85 
Update Live with current Master
@mairaw
Merge pull request #5089 from dotnet/master
87d533e 
Update Live with current Master
@mairaw
Merge branch 'master' into live
58eb8f6
Merge pull request #5106 from dotnet/master
68c3cc2 
Update Live with current Master
@mairaw
Merge pull request #5118 from dotnet/master
11f11ca 
Update live with current master
@mairaw
Merge pull request #5167 from dotnet/master
3d5d33f 
Update Live with current Master
@mairaw
Merge pull request #5193 from dotnet/master
1510984 
Update Live with current Master
@mairaw
Merge branch 'master' into live
42b1a1e
@BillWagner
Merge pull request #5223 from dotnet/master
c03eef7 
update live from master
Merge pull request #5270 from dotnet/master
88f251b 
update live with current master
@mairaw
Merge pull request #5300 from dotnet/master
ff1d405 
Update live with current master
mairaw and others added 24 commits May 18, 2018 20:52
@mairaw
Merge pull request #5480 from dotnet/master
895c760 
Update live with current master
@mairaw
Merge pull request #5542 from dotnet/master
43924ac 
Update live with current master
@mairaw
Merge pull request #5575 from dotnet/master
bce0c52 
Update live with current master
@mairaw
Merge branch 'master' into live
77d9a94
@mairaw
Merge pull request #5599 from dotnet/master
b7763f3 
Update Live with current Master
@mairaw
Merge pull request #5617 from dotnet/master
54231aa 
Update Live with current Master
@mairaw
Merge pull request #5668 from dotnet/master
cd4aef0 
Update live with current master
@mairaw
Merge pull request #5689 from dotnet/master
2e56d4d 
Update live with current master
@carolinacmoravia @mairaw
C18280: Incorrect link structure (#5709)
4eb5c00
@mairaw
Merge pull request #5726 from dotnet/master
3540f61 
Update live with current master
Merge pull request #5760 from dotnet/master
bbf70ab 
Update live with current master
@mairaw
Merge pull request #5788 from dotnet/master
d8bf497 
Update live with current master
@mairaw
Merge pull request #5823 from dotnet/master
fc70fcb 
Update live with current master
@mairaw
Merge pull request #5825 from dotnet/master
5b08028 
Update live with current master
@mairaw
Merge pull request #5844 from dotnet/master
d955cb4 
Update Live with current Master
@BillWagner
Merge pull request #5865 from dotnet/master
2ad7d06 
Update live with current master
@mairaw
Merge pull request #5884 from dotnet/master
6c48077 
Update live with current master
Merge pull request #5913 from dotnet/master
95afc8f 
Update live with current master
@mairaw
Merge branch 'master' into live
73a6623
@mairaw
Merge pull request #5933 from dotnet/master
1e17d85 
Update live with current master
@mairaw
Merge pull request #5965 from dotnet/master
416988a 
Update live with current master
@mairaw
Merge pull request #5980 from dotnet/master
7c0cb6b 
Update live with current master
@mairaw
Merge pull request #6020 from dotnet/master
6bc4efc 
Update live with current master
@imba-tjd
fix method name
01c3f29
@imba-tjd imba-tjd requested a review from BillWagner as a code owner June 20, 2018 07:23
jzeferino
jzeferino approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@jzeferino jzeferino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BillWagner BillWagner changed the base branch from live to master June 20, 2018 15:09
BillWagner
BillWagner approved these changes Jun 20, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @imba-tjd We appreciate it.

I've reviewed the changes, and I'll :shipit: now.

You should see the changes in the english version in the next day or two on our regular publish cycle. The localized versions will follow thereafter.

Note: PRs should target the 'master' branch instead of the 'live' branch. I changed that before merging.

@BillWagner BillWagner merged commit 7814c7b into dotnet:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

+1 more reviewer

@jzeferino jzeferino jzeferino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Sprint 137 (06/11/18 - 06/29/18)

Development

Successfully merging this pull request may close these issues.

5 participants

@imba-tjd @BillWagner @jzeferino @mairaw @carolinacmoravia