Skip to content

Coding convention: use string interpolation for short strings #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2018
Merged

Coding convention: use string interpolation for short strings #4967

merged 1 commit into from
Apr 21, 2018

Conversation

@pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Apr 19, 2018 •
edited
Loading

Snippet update: dotnet/samples#20

@pkulikov pkulikov requested a review from BillWagner as a code owner April 19, 2018 18:57
@pkulikov pkulikov mentioned this pull request Apr 19, 2018
Merged
rpetrusha
rpetrusha approved these changes Apr 21, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pkulikov, for making this change (as well as the change to the code example) so that it conforms to our coding recommendations. We'll merge your PR now.

@rpetrusha rpetrusha merged commit 614d4a1 into dotnet:master Apr 21, 2018
@pkulikov pkulikov deleted the patch-1 branch April 21, 2018 07:44
@Youssef1313 Youssef1313 mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pkulikov @rpetrusha