Skip to content

Code conventions: use string interpolation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2018
Merged

Code conventions: use string interpolation #20

merged 1 commit into from
Apr 20, 2018

Conversation

@pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Apr 19, 2018 •
edited
Loading

Use string interpolation to concatenate short strings.
Supports dotnet/docs#4967

@pkulikov pkulikov requested a review from BillWagner as a code owner April 19, 2018 18:57
@pkulikov pkulikov mentioned this pull request Apr 19, 2018
Merged
rpetrusha
rpetrusha approved these changes Apr 20, 2018
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pkulikov, for making our coding guidelines consistent and modifying both the text and the example. We'll merge your PR now.

@rpetrusha rpetrusha merged commit 92d5aca into dotnet:master Apr 20, 2018
@pkulikov pkulikov deleted the patch-1 branch April 20, 2018 15:46
@mairaw mairaw added the 📁 Repo - samples Indicates PRs done in the samples repo. label Apr 27, 2018
karelz pushed a commit to karelz/samples that referenced this pull request Aug 31, 2018
@pkulikov @karelz
Code conventions: use string interpolation (dotnet#20)
4f02c69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

📁 Repo - samples Indicates PRs done in the samples repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkulikov @rpetrusha @mairaw