Skip to content

Continued response to Tuple topic feedback #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Continued response to Tuple topic feedback #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba586d4
Continued response to Tuple topic feedback
BillWagner May 31, 2017
db4f2f7
respond to feedback (typo)
BillWagner May 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions docs/csharp/tuples.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,20 @@ In this topic, you'll learn the language rules governing Tuples in C# 7,
different ways to use them, and initial guidance on working with Tuples.

> [!NOTE]
> The new tuples features require the `System.ValueTuple` type. For Visual Studio 2017,
> you must add the NuGet package [System.ValueTuple](https://www.nuget.org/packages/System.ValueTuple/), available on the NuGet Gallery.
> Without this package you may get a compilation error similar to `error CS8179: Predefined type 'System.ValueTuple``2' is not defined or imported`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add CS8137 and CS8179 to the sorry-we-don-t-have-specifics... file in the C# compiler error messages directory. I'll open a quick PR to do it and add a few others.

> or `error CS8137: Cannot define a class or member that utilizes tuples because the compiler required type 'System.Runtime.CompilerServices.TupleElementNamesAttribute' cannot be found.`
> The new tuples features require the @System.ValueTuple types.
> You must add the NuGet package [`System.ValueTuple`](https://www.nuget.org/packages/System.ValueTuple/) in order to use it
> on platforms that do not include the types.
>
> This is similar to other language features that rely on types
> delivered in the framework. Examples include `async` and `await`
> relying on the `INotifyCompletion` interface, and LINQ relying
> on `IEnumerable<T>`. However, the delivery mechanism is changing
> as .NET is becoming more platform independent. The .NET Framework
> may not always ship on the same cadence as the language compiler. When new language
> features rely on new types, those types will be available as NuGet packages when
> the language features ship. As these new types get added to the .NET Standard
> API and delivered as part of the framework, the NuGet package requirement will
> be removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me :-)


Let's start with the reasons for adding new Tuple support. Methods return
a single object. Tuples enable you to package multiple values in that single
Expand Down
13 changes: 12 additions & 1 deletion docs/csharp/whats-new/csharp-7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,17 @@ return result;
> The new tuples features require the @System.ValueTuple types.
> You must add the NuGet package [`System.ValueTuple`](https://www.nuget.org/packages/System.ValueTuple/) in order to use it
> on platforms that do not include the types.
>
> This is similar to other language features that rely on types
> delivered in the framework. Example include `async` and `await`
> relying on the `INotifyCompletion` interface, and LINQ relying
> on `IEnumerable<T>`. However, the delivery mechanism is changing
> as .NET is becoming more platform independent. The .NET Framework
> may not always ship on the same cadence as the language compiler. When new language
> features rely on new types, those types will be available as NuGet packages when
> the language features ship. As these new types get added to the .NET Standard
> API and delivered as part of the framework, the NuGet package requirement will
> be removed.

C# provides a rich syntax for classes and structs that is used to explain
your design intent. But sometimes that rich syntax requires extra
Expand Down Expand Up @@ -503,7 +514,7 @@ throw statements in the body of the constructor:
> For that reason, designs that throw exceptions during construction are
> discouraged.

## Generalized async return types
## Generalized async return types

Returning a `Task` object from async methods can introduce
performance bottlenecks in certain paths. `Task` is a reference
Expand Down