Continued response to Tuple topic feedback #2292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of these had been addressed by @svick. Adding the remaining open items.
|
@terrajobst Can you review my edits on types on which language features depend and .NET standard? I want to make sure it's accurate. /cc @richlander |
rpetrusha
approved these changes
May 31, 2017
| @@ -25,10 +25,20 @@ In this topic, you'll learn the language rules governing Tuples in C# 7, | |||
| different ways to use them, and initial guidance on working with Tuples. | |||
|
|
|||
| > [!NOTE] | |||
| > The new tuples features require the `System.ValueTuple` type. For Visual Studio 2017, | |||
| > you must add the NuGet package [System.ValueTuple](https://www.nuget.org/packages/System.ValueTuple/), available on the NuGet Gallery. | |||
| > Without this package you may get a compilation error similar to `error CS8179: Predefined type 'System.ValueTuple``2' is not defined or imported` | |||
There was a problem hiding this comment.
We should add CS8137 and CS8179 to the sorry-we-don-t-have-specifics... file in the C# compiler error messages directory. I'll open a quick PR to do it and add a few others.
docs/csharp/tuples.md
Outdated
| > on platforms that do not include the types. | ||
| > | ||
| > This is similar to other language features that rely on types | ||
| > delivered in the framework. Example include `async` and `await` |
terrajobst
approved these changes
May 31, 2017
| > features rely on new types, those types will be available as NuGet packages when | ||
| > the language features ship. As these new types get added to the .NET Standard | ||
| > API and delivered as part of the framework, the NuGet package requirement will | ||
| > be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1889
Much of these had been addressed by @svick in PR #1842. Adding the remaining open
items.