Skip to content

Touch-ups to GC config knobs #15914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2019
Merged

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 21, 2019

Preview link: https://review.docs.microsoft.com/en-us/dotnet/core/run-time-config/garbage-collector?branch=pr-en-us-15914

@gewarren gewarren requested a review from Maoni0 November 21, 2019 02:18
@Maoni0
Copy link
Member

Maoni0 commented Nov 21, 2019

LGTM! BTW, I apologize - I forgot to mention that for the GCLOHThreshold config we should note that you can only specify a value that's larger than the default (which is 85000 bytes).

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo @Maoni0's comment

@gewarren
Copy link
Contributor Author

Thanks all for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants