-
Notifications
You must be signed in to change notification settings - Fork 6k
Add run-time GC settings #15844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run-time GC settings #15844
Conversation
This reverts commit d9abdea.
@Maoni0 I made the changes we discussed. Can you take a look at https://review.docs.microsoft.com/en-us/dotnet/core/run-time-config/garbage-collector?branch=pr-en-us-15844? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @gewarren. Left a few comments for you to consider.
docs/framework/unmanaged-api/profiling/cor-prf-high-monitor-enumeration.md
Outdated
Show resolved
Hide resolved
This PR also touches on #2645 |
items: | ||
- name: Exposing .NET Core Components to COM | ||
- name: Settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the new section to the breadcrumb file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like only the Tools and Compatibility subdirectories currently have an entry in the breadcrumb file. Is there a plan to add all the other subdirectories too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an oversight. Can you file an issue for us to review that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great work @gewarren
I had a few comments to consider before you merge it.
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com> Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @mairaw and @BillWagner . I'll merge this now. @Maoni0 if you have further revisions we can address them in a separate PR. |
thanks @gewarren! sorry I didn't get to this yesterday - I'm reviewing now. |
* feedback from maoni on pr #15844 * add new app.config setting file * add more info about decimal/hexadecimal * feedback from maoni and petr
Fixes #13425.
Contributes to #15850.