Skip to content

Add run-time GC settings #15844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 20, 2019
Merged

Add run-time GC settings #15844

merged 22 commits into from
Nov 20, 2019

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 14, 2019

Fixes #13425.
Contributes to #15850.

@gewarren gewarren changed the title Add configuration knob settings Add run-time GC settings Nov 18, 2019
@gewarren gewarren requested a review from Maoni0 November 19, 2019 02:13
@gewarren gewarren marked this pull request as ready for review November 19, 2019 02:13
@gewarren
Copy link
Contributor Author

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @gewarren. Left a few comments for you to consider.

@mairaw
Copy link
Contributor

mairaw commented Nov 19, 2019

This PR also touches on #2645

items:
- name: Exposing .NET Core Components to COM
- name: Settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the new section to the breadcrumb file

Copy link
Contributor Author

@gewarren gewarren Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like only the Tools and Compatibility subdirectories currently have an entry in the breadcrumb file. Is there a plan to add all the other subdirectories too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably an oversight. Can you file an issue for us to review that?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work @gewarren

I had a few comments to consider before you merge it.

gewarren and others added 3 commits November 19, 2019 11:42
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@gewarren gewarren removed the request for review from Thraka November 19, 2019 20:08
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @gewarren

I'll approve this now.

Once you're ready, you can :shipit:

@gewarren
Copy link
Contributor Author

Thanks for the review @mairaw and @BillWagner . I'll merge this now. @Maoni0 if you have further revisions we can address them in a separate PR.

@gewarren gewarren merged commit 35e6af6 into dotnet:master Nov 20, 2019
@gewarren gewarren deleted the core-config branch November 20, 2019 18:33
@Maoni0
Copy link
Member

Maoni0 commented Nov 20, 2019

thanks @gewarren! sorry I didn't get to this yesterday - I'm reviewing now.

gewarren added a commit to gewarren/docs that referenced this pull request Nov 21, 2019
gewarren added a commit that referenced this pull request Nov 21, 2019
* feedback from maoni on pr #15844

* add new app.config setting file

* add more info about decimal/hexadecimal

* feedback from maoni and petr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document additional GC settings
5 participants