Refresh .NET article: Determine installed versions of .NET Framework #10513
Conversation
…efresh-determine-versions
…efresh-determine-versions
|
@dksimpson, we've merged a PR that's created a huge number of merge commits. I'm not quite sure how to proceed, given that they're extensive and GitHub doesn't seem to do a good job of identifying them very precisely. Do you want to take a look? |
|
@rpetrusha I've fixed the merge errors with a new commit. More commits to follow as I make additional edits. |
…efresh-determine-versions
|
Thanks, @dksimpson. Let me know when your PR is ready for review. |
…efresh-determine-versions
…efresh-determine-versions
…efresh-determine-versions
|
Hi @rpetrusha, I've finished my updates - the PR is ready for your review. |
There was a problem hiding this comment.
I've left a couple of minor comments, @dksimpson, but you've really done an outstanding job in improving the organization and flow of this article!
| @@ -14,85 +14,71 @@ ms.author: "ronpet" | |||
| --- | |||
| # How to: Determine which .NET Framework versions are installed | |||
|
|
|||
| Users can install and run multiple versions of the .NET Framework on their computers. When you develop or deploy your app, you might need to know which .NET Framework versions are installed on the user’s computer. Note that the .NET Framework consists of two main components, which are versioned separately: | |||
| When users [install the .NET Framework](https://docs.microsoft.com/dotnet/framework/install), they can install and run multiple versions of it on their computers. For an app that you develop or deploy to run properly on a user's computer, it might need to know which .NET Framework versions are installed. | |||
There was a problem hiding this comment.
The original first sentence seems clearer, although adding the link is a good idea. But to me at least implies that when you install the .NET Framework, you can end up with multiple versions.
|
|
||
| 1. The existence of the `Release` DWORD in the `HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full` key indicates that the .NET Framework 4.5 or later is installed on a computer. The value of the keyword indicates the installed version. To check this keyword, use the <xref:Microsoft.Win32.RegistryKey.OpenBaseKey%2A?displayProperty=nameWithType> and <xref:Microsoft.Win32.RegistryKey.OpenSubKey%2A?displayProperty=nameWithType> methods to access the subkey in the Windows registry. | ||
| The existence of the **Release** DWORD entry in the subkey indicates that the .NET Framework 4.5 or a later version is installed on a computer. |
There was a problem hiding this comment.
| The existence of the **Release** DWORD entry in the subkey indicates that the .NET Framework 4.5 or a later version is installed on a computer. | |
| The existence of the **Release** DWORD entry indicates that the .NET Framework 4.5 or a later version is installed on a computer. |
I found the "in a subkey" phrase to be an unclear reference -- I wasn't sure whether it was the subkey in #1 or a different subkey or a subkey of that subkey. It's best either to restore the text ("in the xxx subkey") or not mention the subkey.
…efresh-determine-versions
|
Hi @rpetrusha, thanks for your comments - I've incorporated your suggested updates. Ready for review. |
|
Thanks both for the revisions and the additional changes, @dksimpson. I've approved your PR, and I'll merge it now. |
Summary
Task 1385005: https://mseng.visualstudio.com/TechnicalContent/_workitems/edit/1385005/