Skip to content

Redesigned the layout of the detect .NET Framework versions - fixed bugs - added info #16967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2020

Conversation

Thraka
Copy link
Contributor

@Thraka Thraka commented Feb 4, 2020

Summary

Fixes #14931
Fixes #5120
Fixes #5710
Fixes #15053

@gewarren I still had some bugs assigned to me and I didn't realize you had this article in your code owner area.

@Thraka Thraka requested a review from gewarren as a code owner February 4, 2020 02:27
@dotnet-bot dotnet-bot added this to the February 2020 milestone Feb 4, 2020
@Thraka Thraka changed the title Redesigned the layout of the detect .NET Framework versions Redesigned the layout of the detect .NET Framework versions - fixed bugs - added info Feb 4, 2020
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Thraka and others added 2 commits February 4, 2020 07:02
Co-Authored-By: Genevieve Warren <gewarren@microsoft.com>
@Thraka
Copy link
Contributor Author

Thraka commented Feb 4, 2020

@gewarren Got these fixed up.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Thraka Thraka merged commit 50f4b04 into master Feb 7, 2020
@Thraka Thraka deleted the adegeo-15053-framework-versions branch February 7, 2020 17:25
jcurl added a commit to jcurl/RJCP.DLL.CrashReporter that referenced this pull request Feb 8, 2020
Use the new information in pull request dotnet/docs#16967, to detect .NET on Windows 1909.

Issue: HELIOS-1370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants