Skip to content

Replace ErrorCodes with ReturnCode #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2025
+4 −16
Merged

Replace ErrorCodes with ReturnCode #5624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1320221
Initial plan
Copilot Oct 29, 2025
ac8604b
Deprecate ErrorCodes in favor of ReturnCode
Copilot Oct 29, 2025
4d16742
Task completed: ErrorCodes deprecated in favor of ReturnCode
Copilot Oct 29, 2025
38a03e6
Remove ErrorCode.cs and .nuget/nuget.exe
Copilot Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Tools/dotnet-trace/CommandLine/Commands/ConvertCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.Internal.Common;
using Microsoft.Internal.Common.Utils;

namespace Microsoft.Diagnostics.Tools.Trace
{
Expand All @@ -21,12 +22,12 @@ public static int ConvertFile(TextWriter stdOut, TextWriter stdError, FileInfo i
if (!Enum.IsDefined(format))
{
stdError.WriteLine($"Please specify a valid option for the --format. Valid options are: {string.Join(", ", Enum.GetNames<TraceFileFormat>())}.");
return ErrorCodes.ArgumentError;
return (int)ReturnCode.ArgumentError;
}

if (!ValidateNetTraceHeader(stdError, inputFilename.FullName))
{
return ErrorCodes.ArgumentError;
return (int)ReturnCode.ArgumentError;
}

string outputFilename = TraceFileFormatConverter.GetConvertedFilename(inputFilename.FullName, output?.FullName, format);
Expand Down Expand Up @@ -83,7 +84,7 @@ static int CopyNetTrace(TextWriter stdOut, TextWriter stdError, string inputfile
catch (Exception ex)
{
stdError.WriteLine($"Error copying nettrace to {outputfile}: {ex.Message}");
return ErrorCodes.UnknownError;
return (int)ReturnCode.UnknownError;
}

return 0;
Expand Down
13 changes: 0 additions & 13 deletions src/Tools/dotnet-trace/CommandLine/Commands/ErrorCode.cs
View file
Open in desktop

This file was deleted.