Replace ErrorCodes with ReturnCode

[Copilot]

ErrorCodes in dotnet-trace and ReturnCode in Common are redundant. ReturnCode is the established standard across diagnostic tools (dotnet-trace, dotnet-counters) and provides better type safety as an enum. ErrorCodes existed only for legacy ConvertCommand usage.

Changes

• ConvertCommand.cs: Migrated from ErrorCodes to ReturnCode

  • Added using Microsoft.Internal.Common.Utils
  • Replaced ErrorCodes.ArgumentError → (int)ReturnCode.ArgumentError
  • Replaced ErrorCodes.UnknownError → (int)ReturnCode.UnknownError

• ErrorCode.cs: Removed completely

  • No longer needed as ConvertCommand now uses ReturnCode directly

- return ErrorCodes.ArgumentError;
+ return (int)ReturnCode.ArgumentError;

This standardizes error code handling across all diagnostic tools.

Testing

• ✅ Build succeeded with 0 warnings, 0 errors
• ✅ All 109 dotnet-trace unit tests passed

Original prompt

Can you assess the history of ErrorCode in src/Tools/dotnet-trace/CommandLine/Commands/ErrorCode.cs and ReturnCode in src/Tools/Common/Commands/Utils.cs. Can you assess whether they are overlapping in responsibility, and if so, can you deprecate ErrorCode in favor of ReturnCode?

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[mdh1418]

@copilot Could we just remove ErrorCode.cs completely?

[Copilot]

@copilot Could we just remove ErrorCode.cs completely?

Done! ErrorCode.cs has been removed completely in commit 38a03e6. Also removed the accidentally added .nuget/nuget.exe file.

[hoyosjs]

@microsoft-github-policy-service rerun