Skip to content

Fix dotnet-trace rundown default #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikem8361 merged 1 commit into from
Feb 5, 2024
Merged

Fix dotnet-trace rundown default #4498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tools/dotnet-trace/Profile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public Profile(string name, IEnumerable<EventPipeProvider> providers, string des

public string Description { get; }

public bool Rundown { get; set; }
Copy link
Member

@hoyosjs hoyosjs Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this in the commandline options, have the default be true, and not pass down a nullable.

Copy link
Contributor Author

@mikem8361 mikem8361 Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Profile change is still necessary and a lot simpler for this release fix. We can fix it in main that way if you want.

Copy link
Member

@Maoni0 Maoni0 Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need to take care of the case that if the user specified both profile and rundown on the commandline, the specified rundown should override what the profile specifies.

public bool Rundown { get; set; } = true;

public static void MergeProfileAndProviders(Profile selectedProfile, List<EventPipeProvider> providerCollection, Dictionary<string, string> enabledBy)
{
Expand Down