Fix dotnet-trace rundown default #4498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikem8361
requested review from
Maoni0 and
hoyosjs
and removed request for
hoyosjs
davmason
approved these changes
Feb 5, 2024
hoyosjs
reviewed
Feb 5, 2024
|
|
||
| public string Description { get; } | ||
|
|
||
| public bool Rundown { get; set; } |
Member
There was a problem hiding this comment.
We should change this in the commandline options, have the default be true, and not pass down a nullable.
Contributor
Author
There was a problem hiding this comment.
The Profile change is still necessary and a lot simpler for this release fix. We can fix it in main that way if you want.
Member
There was a problem hiding this comment.
we still need to take care of the case that if the user specified both profile and rundown on the commandline, the specified rundown should override what the profile specifies.
Maoni0
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.