This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Port IndexOfAny 2 & 3 char special case - #4391
Merged
Merged
Conversation
jkotas
reviewed
Aug 26, 2017
| char c = *pCh; | ||
|
|
||
| if (c == value1 || c == value2) | ||
| goto ReturnIndex; |
Member
There was a problem hiding this comment.
Could you please incorporate dotnet/coreclr#13505 to this change as well?
Contributor
Author
There was a problem hiding this comment.
Oh missed that one getting merged. Done
Contributor
Author
There was a problem hiding this comment.
Note String.Comparison.cs is different in RT and that code port was not needed.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port dotnet/coreclr#13219