This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Undo a few JIT layout workarounds - #13505
Merged
Merged
Conversation
Remove some `goto`s that were added to work around #9692 (poor code layout for loop exit paths) -- the JIT's layout decisions were improved in dotnet#13314, and these particular `goto`s are no longer needed; crossgen of System.Private.CoreLib now produces the same machine code with or without this change. Part of #13466.
Author
|
@stephentoub / @jkotas PTAL This updates the places that can be updated without affecting the native code; https://github.com/dotnet/coreclr/issues/13466#issuecomment-323831444 discusses the other places. |
stephentoub
approved these changes
Aug 21, 2017
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Aug 26, 2017
* Port IndexOfAny 2 & 3 char special case * Undo a few JIT layout workarounds (dotnet/coreclr#13505)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some
gotos that were added to work around #9692 (poor codelayout for loop exit paths) -- the JIT's layout decisions were improved
in #13314, and these particular
gotos are no longer needed; crossgenof System.Private.CoreLib now produces the same machine code with or
without this change.
Part of #13466.