This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.1] Handle NT auth with Connection: close on initial challenge #31527 #31589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we receive an initial NT auth challenge that has Connection: close set on the response, we need to proceed with authentication on a new connection. Fixes #30327
davidsh
changed the title
Contributor
Author
|
@dotnet-bot test Outerloop Windows x64 Debug Build |
geoffkizer
approved these changes
Aug 4, 2018
Contributor
Author
|
@dotnet-bot Test Outerloop Windows x64 Debug Build @dotnet-bot Test Outerloop OSX x64 Debug Build |
Contributor
Author
|
CI Failures are unrelated. The PR is ready to merge. |
davidsh
added a commit
that referenced
this pull request
Sep 13, 2018
…etes (#32243) PR #31589 introduced a regression in the case where we receive another 401 after Windows auth completes (this is caused by the user being successfully authenticated, but not authorized to access the specified resource). We were incorrectly draining the response in this case. As a result, the user would receive a disposed response and eventually throw an ObjectDisposedException. The fix is to adjust the logic here where we only drain if we know we are going to send another request for the rest of the Windows auth (Negotiate/NTLM) challenge-response handshake. Add new unit test for Windows auth scenario.
danmoseley
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive an initial NT auth challenge that has Connection: close set on the response,
we need to proceed with authentication on a new connection.
Fixes #30327