This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Handle NT auth with Connection: close on initial challenge #31527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dotnet-bot test outerloop Linux x64 debug build |
Contributor
|
I've done a bunch of manual tests with Windows auth scenarios and so far things look good. I'll do more testing and hopefully merge this soon. |
davidsh
approved these changes
Aug 3, 2018
jamshedd
added a commit
that referenced
this pull request
Aug 30, 2018
[release/2.1] Handle NT auth with Connection: close on initial challenge #31527
stephentoub
reviewed
Sep 24, 2018
| // Server is closing the connection and asking us to authenticate on a new connection. | ||
| (connection, response) = await connectionPool.CreateHttp11ConnectionAsync(request, cancellationToken).ConfigureAwait(false); | ||
| if (response != null) | ||
| { |
Member
There was a problem hiding this comment.
Nit: Assert that connection is null? If the logic in CreateHttp11ConnectionAsync changes such that both connection and response could be non-null, then the connection pool's count tracking will end up being incorrect.
stephentoub
reviewed
Sep 24, 2018
| else | ||
| { | ||
| return await connection.SendAsync(request, cancellationToken).ConfigureAwait(false); | ||
| } |
Member
There was a problem hiding this comment.
Nit: FWIW, code gen would end up being a bit better if this were instead written to have a single await instead of two, e.g.
Task<HttpResponseMessage> resp = connection is HttpConnection httpConnection ?
SendWithNtConnectionAuthAsync(httpConnection, request, doRequestAuth, cancellationToken) :
connection.SendAsync(request, cancellationToken);
return await resp.ConfigureAwait(false);
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…refx#31527) When we receive an initial NT auth challenge that has Connection: close set on the response, we need to proceed with authentication on a new connection. Fixes dotnet/corefx#30327 Commit migrated from dotnet/corefx@eedddac
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30327.
When we receive an initial NT auth challenge that has Connection: close set on the response, we need to proceed with authentication on a new connection.
@davidsh @dotnet/ncl