Merge master into dev/api #11366
Merge master into dev/api #11366
Conversation
RegistryKey.OpenSubKey should remove multiple/trailing slashes
Add some tests to System.Reflection.Emit
And cleanup existing tests
Consume Roslyn Compiler 2.0.0-beta3
…cies Update CoreFx to beta-24419-02 (master)
Update build tools to pick up fix for Linux tests.
Cleanup System.Reflection.TypeExtensions.ConstructorInfo tests
RegistryKey's name fix-up implementation uses a mark-and-sweep
approach. If there are multiple slashes, any extra slash chars will be
replaced with a marker char ('\uffff'), and then all '\uffff' chars
will be removed, including any pre-existing '\uffff' chars.
If there aren't multiple slashes, any '\uffff' chars should remain.
This commit adds new tests to pin this behavior.
Update BuildToolsVersion.txt
Also cleans up EditableAttribute and EmailAddressAttribute tests
…-tests Add and cleanup CustomValidationAttribute tests
…cies Update CoreClr to beta-24419-03 (master)
…#10940) * Add some tests for invalid inputs to MemberAccess expressions * Address PR feedback * Add test for no accessors in ProperyInfo
RegistryKey: Flesh out tests
* Add tests for invalid inputs to Expression.New Also adds some param names that were brought up from these tests
Cleanup EnumDataTypeAttribute tests
Add and cleanup tests for DataTypeAttribute
Fixed incorrect x64 #import for ol.7.0 RID
set __CrossBuild in src/Native/build-native.sh automatically
ARM-CI : Check a device is already mounted while mounting a device.
Cleanup AssociationAttributeTests
66% speedup for Path.Combine on Windows
Removing obselute uex file reference comments in code
…cies Update CoreFx to beta-24501-02 (master)
|
Changes that I had to do in order to get this building are in bf7911a |
|
Looking into the non-Windows test failures... |
|
After analyzing the tests failures in an OSX and an Ubuntu machine, looks like the 8 test projects that have failures are all because of the same reason: They are missing System.Security.Cryptography.Native.OpenSsl native binary in the test folder. I checked and it looks like that package doesn't exist yet in the dev/api myget feed, and I can't seem to get it to work by adding a .pkgproj reference to the native project that drops that binary. Any help is appreciated. |
Could the one from the core feed be manually pushed to dev-api feed for bootstrapping? |
|
FWIW diff on master vs dev\api from https://github.com/dotnet/versions/tree/master/build-info/dotnet/corefx shows these as missing (not just OpenSsl): runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl Here's the new ones: |
we could, but I believe that wouldn't be enough as we would also need to push an update for Microsoft.NETCore.Targets package since this is the one that pulls the openSsl native package in. Given there is already one of these in our feed with the matching prerelease, I believe we would have to remove the one that's there and then push the updated version of it keeping the same prerelease. One other option, would be to disable these 8 test projects for non-Windows runs until we update the corefx packages in dev/api, which would even probably happen today as well. @stephentoub @weshaggard thoughts? |
|
I would have expected your change for TestWithLocalNativeLibraries to actually have solved this. Let's look at a repro to find out why that's not happening. |
|
With the help of @ericstj I finally know what the problem is and how to fix it. It will require a buildtools update. I'll update this PR very soon. |
|
@dotnet-bot test Innerloop CentOS7.1 Release Build and Test please (segfault during System.Runtime.Tests) |
|
Due to PR #11341 you might want to run some [outerloop] passes on this. Otherwise you are not getting any networking test coverage. |
Merge master into dev/api Commit migrated from dotnet/corefx@8126ed0
Merging branch master into dev/api
cc: @weshaggard @danmosemsft @stephentoub @ericstj
FYI: @tarekgh @sepidehms