This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Further tests for String.Concat and String.Join #10966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var iEnumerableObject = new List<object>(values); | ||
| Assert.Equal(expected, string.Join(seperator, iEnumerableObject)); | ||
|
|
||
| // We're taking advantage of covariant arrays (which is bad) here, | ||
| // but this should not be a problem since Join shouldn't write to the array |
There was a problem hiding this comment.
This comment isn't necessary.
|
One nit, otherwise LGTM. Thanks. |
jamesqo
force-pushed
the
string-join-concat-tests
branch
from
1807f0f to
d594865
Compare
|
I ran into a few quirks including the |
|
LGTM. Thanks for the additions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the test coverage for string.Concat and string.Join by calling
Join<T>andConcat<T>with a type parameter of string, as well as adding tests for a couple of other edge cases..cc @hughbe @stephentoub