This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Re-enable jit regression test DevDiv_590771 #18724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandreenko PTAL |
|
@dotnet-bot test Windows_NT x64_arm64_altjit Checked r2r_jitstress1 |
|
Hmm, windows arm legs are failing on the new zero sized struct test GitHub_18522_8.... will investigate. |
|
`Assertion failed 'temp != nullptr' is a recent regression, I am searching when it was introduced. |
|
Ah, there's a typo in the test.lst file. Need to rebase, so will do that and fix the typo. |
The issue the test was hitting was worked around in dotnet#18282. Fixes #17967. Also add GitHub_18522_8 to the arm/arm64 lists (from dotnet#18708).
|
@BruceForstall PTAL |
BruceForstall
approved these changes
Jul 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue the test was hitting was worked around in #18292.
Fixes #17967.
Also add GitHub_18522_8 to the arm/arm64 lists (from #18708).