This repository was archived by the owner on Jan 23, 2023. It is now read-only.
JIT: fix regression when returning struct with no fields on SysV #18708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime classifies such structs as being returned by reference, so we need to follow suit in the jit. If the classifier says the value can't be returned in a register, then so be it. Add a test case.
|
@briansull PTAL Verified CSharp tests pass on Unix with this change. One minor (and inconsequential diff) from PMI over fx (as the jit was self-consistent, but did not agree w/ the runtime). Expected diffs in new test case and in the CoreFX test case code. |
|
cc @dotnet/jit-contrib |
|
Would this explain the difference seen in https://github.com/dotnet/coreclr/issues/18672#issuecomment-400806623? |
|
@jakobbotsch I don't think so -- even though #18672 has a struct |
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Jun 29, 2018
The issue the test was hitting was worked around in dotnet#18282. Fixes #17967. Also add GitHub_18522_8 to the arm/arm64 lists (from dotnet#18708).
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Jul 2, 2018
The issue the test was hitting was worked around in dotnet#18282. Fixes #17967. Also add GitHub_18522_8 to the arm/arm64 lists (from dotnet#18708).
AndyAyersMS
added a commit
that referenced
this pull request
Jul 4, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…net/coreclr#18708) The runtime classifies such structs as being returned by reference, so we need to follow suit in the jit. If the classifier says the value can't be returned in a register, then so be it. Add a test case. Commit migrated from dotnet/coreclr@65d3199
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime classifies such structs as being returned by reference, so we
need to follow suit in the jit. If the classifier says the value can't be
returned in a register, then so be it.
Add a test case.