This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port build-test.sh changes from master to release/2.1 #17965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unix test build by removing unnecessary 'managed_test_build' semafore file
* Split unix test builds in slices Ports dotnet#17161 to linux * Address review feedback
jashook
changed the title
|
Please feel free to add whoever needs to review the 2.1 change. |
|
Centos build is complete but looks frozen. Arm machines were offline and now working but still have quite a bit of time to complete. Either way this change will not affect windows arm testing. Merging before CI finishes to meet 3pm deadline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses https://github.com/dotnet/coreclr/issues/17924. In summary, build-test.sh was broken and tracked with https://github.com/dotnet/coreclr/issues/17503. @4creators's #17725 fixed issue #17503; however, was never ported to release/2.1.
This will port those changes to release/2.1 to allow using build-test.sh correctly. In addition, this change cherry-picks #17785 to bring build-test.sh to closer to build-test.cmd in release/2.1.
Fixes https://github.com/dotnet/coreclr/issues/17924.
!! Note !!
This change does not affect the 2.1 product. As of release/2.1 build-test.sh's test build is also not used in any infrastructure, so this change should be very low risk.