This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix unix test build by removing unnecessary 'managed_test_build' semafore file #17725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore file Fixes #17503 The error is caused by both: 1. Unnecessary usage of 'managed_test_build' semaphore file which is incorrectly set after /t:BatchRestorePackages build target and prevents managed test build which is invoked after semaphore alredy exists 2. Masked by the above error is a wrong condition in dirs.proj non-windows test build which was introduced by PR dotnet#17161 and which prevented unix build due to missing dotnet#17161 group build port to unix
|
@4creators thank you for looking at this. I will review later today. |
BruceForstall
approved these changes
Apr 24, 2018
jashook
pushed a commit
to jashook/coreclr
that referenced
this pull request
May 11, 2018
Fix unix test build by removing unnecessary 'managed_test_build' semafore file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17503
The error is caused by both:
set after /t:BatchRestorePackages build target and prevents managed test build
which is invoked after semaphore alredy exists
which was introduced by PR Improve Windows test build performance by building projects in groups - 4x less memory 326% faster build. #17161 and which prevented unix build due to missing
Improve Windows test build performance by building projects in groups - 4x less memory 326% faster build. #17161 group build port to unix