-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use live code flow for corefx dependency and react to S.T.Json breaks #11639
Conversation
a5eafd9
to
3420deb
Compare
@ahsonkhan @wli3 Can you review 3420deb now. I'm still working on the rest to get this to green, but don't want to block on anything I might have gotten wrong with the S.T.Json part. |
working on it |
now i realize to make test work is tricky. we can build against ref assembly, but when we run tests we need the actual one. I think we have to take a dependency on the latest runtime in this case. we don't have to overlay it over stage0 tho |
I am pulling down the corresponding runtime: https://github.com/dotnet/cli/pull/11639/files#diff-274660eb4b1b1d963a330b471e10f41cR9 |
But something about our tests make it so it doesn't actually run on them. I'll work on that in the morning. |
Other repos have done this successfully, so it shouldn't be too bad. (Famous last words. :)) |
I had a round of review of 3420deb against the breaking change email. It looks good. |
I believe this will be green now. Ready for review. |
These look good to me. |
Fix #11520 -- We no longer require a cyclical stage 0 update to consume corefx changes
WIP: Tests aren't picking up the newer runtime we're acquiring yet. Also need to make similar change in toolset, and make sure darc subscriptions get updated.