Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Use live code flow for corefx dependency and react to S.T.Json breaks #11639

Merged
merged 4 commits into from
Jun 27, 2019

Conversation

nguerrera
Copy link
Contributor

@nguerrera nguerrera commented Jun 26, 2019

Fix #11520 -- We no longer require a cyclical stage 0 update to consume corefx changes

WIP: Tests aren't picking up the newer runtime we're acquiring yet. Also need to make similar change in toolset, and make sure darc subscriptions get updated.

@nguerrera nguerrera added this to the 3.0.1xx milestone Jun 26, 2019
@nguerrera nguerrera force-pushed the corefx-flow branch 2 times, most recently from a5eafd9 to 3420deb Compare June 27, 2019 04:57
@nguerrera
Copy link
Contributor Author

nguerrera commented Jun 27, 2019

@ahsonkhan @wli3 Can you review 3420deb now. I'm still working on the rest to get this to green, but don't want to block on anything I might have gotten wrong with the S.T.Json part.

@wli3
Copy link

wli3 commented Jun 27, 2019

working on it

@nguerrera nguerrera changed the title WIP: Use code flow for corefx Use live code flow for corefx dependency and react to S.T.Json breaks Jun 27, 2019
@wli3
Copy link

wli3 commented Jun 27, 2019

now i realize to make test work is tricky. we can build against ref assembly, but when we run tests we need the actual one. I think we have to take a dependency on the latest runtime in this case. we don't have to overlay it over stage0 tho

@nguerrera
Copy link
Contributor Author

I am pulling down the corresponding runtime: https://github.com/dotnet/cli/pull/11639/files#diff-274660eb4b1b1d963a330b471e10f41cR9

@nguerrera
Copy link
Contributor Author

But something about our tests make it so it doesn't actually run on them. I'll work on that in the morning.

@nguerrera
Copy link
Contributor Author

Other repos have done this successfully, so it shouldn't be too bad. (Famous last words. :))

@wli3
Copy link

wli3 commented Jun 27, 2019

I had a round of review of 3420deb against the breaking change email. It looks good.

@nguerrera nguerrera marked this pull request as ready for review June 27, 2019 18:06
@nguerrera
Copy link
Contributor Author

I believe this will be green now. Ready for review.

@ahsonkhan
Copy link

ahsonkhan commented Jun 27, 2019

@ahsonkhan @wli3 Can you review 3420deb now. I'm still working on the rest to get this to green, but don't want to block on anything I might have gotten wrong with the S.T.Json part.

These look good to me.

@nguerrera nguerrera merged commit 6b08851 into dotnet:master Jun 27, 2019
@nguerrera nguerrera deleted the corefx-flow branch June 27, 2019 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI should not use stage0 SDK for reference assemblies
3 participants