Skip to content

Conversation

@mitchdenny
Copy link
Member

This PR adds a [HelixQueues] attribute. The goal of this attribute is to allow us to succinctly opt-in to a specific queue once without having to exclude all other queues - that said, the usage is a bit more flexible than that and it could potentially replace the existing [SkipOnHelix] attribute. Usage:

[HelixQueues(Includes = HelixConstants.NativeAotSupportedQueues)]
public void MyTestMethod()
{
}

You can also specify excludes:

[HelixQueues(Includes = "*", Excludes = "All.Windows")]
public void MyTestMethod()
{
}

This PR also adds "All.Windows" as a special value along-side the existing "All.OSX" and "All.Ubuntu" values.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 8, 2023
@ghost
Copy link

ghost commented May 8, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@BrennanConroy
Copy link
Member

An issue with this attribute is that if we change a queue any tests that "target" that queue will silently stop running.

@mitchdenny
Copy link
Member Author

That is a fair point. The flip-side is that for some tests, like the AOT tests presently - every time we add a new queue the tests start breaking which is a pain.

@BrennanConroy
Copy link
Member

IMO visibility (and a little pain of fixing broken tests) is far better than silently not running tests.

@mitchdenny
Copy link
Member Author

mitchdenny commented May 8, 2023

Upon reflection, I think I agree with you. As painful as this is :) .... (having to remove queues occasionally, not agreeing with you)

@mitchdenny mitchdenny closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants