-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Skip more OS's for AOT tests #48090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip more OS's for AOT tests #48090
Conversation
|
I think @mitchdenny's question here #48022 (comment) makes a lot of sense:
|
|
|
||
| [ConditionalFact] | ||
| [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47478", Queues = "OSX.13.Amd64.Open;Ubuntu.2004.Amd64.Open;Windows.11.Amd64.Client.Open;")] | ||
| [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47478", Queues = "All.OSX;All.Ubuntu;Windows.11.Amd64.Client.Open;Windows.Amd64.Server2022.Open;windows.11.arm64.open")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check
Windows.11.Amd64.Client.Open;Windows.Amd64.Server2022.Open;windows.11.arm64.open
None of those Helix queues have VS installed on them, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we extract this string into a constant, ex. NativeAotSupportedHelixQueues or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amd64.Server2022 doesn't seem to have C++ tools installed
Windows.11.Arm64 was failing with: Unable to find package Microsoft.AspNetCore.App.Runtime.win-arm64 with version (= 8.0.0-ci) so unsure if it has VS or not
Windows.11.Amd64 was already skipped. Don't know its status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this out: |
|
Hi @mitchdenny. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
No description provided.