Skip to content

Conversation

@BrennanConroy
Copy link
Member

No description provided.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 5, 2023
@eerhardt
Copy link
Member

eerhardt commented May 5, 2023

I think @mitchdenny's question here #48022 (comment) makes a lot of sense:

@wtgodbe is there a way with the Helix attributes that you want a test to opt into a queue rather than opt out? Seems like in the long term opting out of queues is inefficient for some test cases (although opting out is good for test cases where we know we can achieve broad platform coverage).


[ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47478", Queues = "OSX.13.Amd64.Open;Ubuntu.2004.Amd64.Open;Windows.11.Amd64.Client.Open;")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47478", Queues = "All.OSX;All.Ubuntu;Windows.11.Amd64.Client.Open;Windows.Amd64.Server2022.Open;windows.11.arm64.open")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check

Windows.11.Amd64.Client.Open;Windows.Amd64.Server2022.Open;windows.11.arm64.open

None of those Helix queues have VS installed on them, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extract this string into a constant, ex. NativeAotSupportedHelixQueues or similar?

Copy link
Member Author

@BrennanConroy BrennanConroy May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amd64.Server2022 doesn't seem to have C++ tools installed
Windows.11.Arm64 was failing with: Unable to find package Microsoft.AspNetCore.App.Runtime.win-arm64 with version (= 8.0.0-ci) so unsure if it has VS or not
Windows.11.Amd64 was already skipped. Don't know its status.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just put up a PR for a new attribute to try and make this easier moving forward:

#48117

PTAL.

@BrennanConroy BrennanConroy merged commit edea790 into main May 5, 2023
@BrennanConroy BrennanConroy deleted the brecon/badaot branch May 5, 2023 19:42
@ghost ghost added this to the 8.0-preview5 milestone May 5, 2023
@mitchdenny
Copy link
Member

I think @mitchdenny's question here #48022 (comment) makes a lot of sense:

@wtgodbe is there a way with the Helix attributes that you want a test to opt into a queue rather than opt out? Seems like in the long term opting out of queues is inefficient for some test cases (although opting out is good for test cases where we know we can achieve broad platform coverage).

Check this out:

#48117

@ghost
Copy link

ghost commented May 8, 2023

Hi @mitchdenny. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants