Stop Calling JSON GetTypeInfo with the runtime type #47859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
added
area-web-frameworks
src/Http/Http.Extensions/gen/RequestDelegateGeneratorSources.cs
Outdated
Show resolved
Hide resolved
Calling GetTypeInfo with the object's runtime type doesn't work when using unspeakable types and using JSON source generation. There is no way to mark the unspeakable type (like a C# compiler implemented IAsyncEnumerable iterator) as JsonSerializable. Instead, when the "declared type"'s JsonTypeInfo isn't compatible with the runtime type w.r.t. polymorphism, serialize the value "as object", letting System.Text.Json's serialization take over to serialize the value. Fix dotnet#47548
eerhardt
force-pushed
the
FixGetTypeInfoOnUnspeakableTypes
branch
from
c8e1046 to
c771a2a
Compare
eerhardt
requested review from
a team,
Tratcher,
BrennanConroy and
halter73
as code owners
| @@ -108,9 +109,7 @@ public static partial class HttpResponseJsonExtensions | |||
| /// <param name="contentType">The content-type to set on the response.</param> | |||
| /// <param name="cancellationToken">A <see cref="CancellationToken"/> used to cancel the operation.</param> | |||
| /// <returns>The task object representing the asynchronous operation.</returns> | |||
| #pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters | |||
There was a problem hiding this comment.
Why do these no longer apply?
There was a problem hiding this comment.
IDK. It builds without them... 🤷
...Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.Responses.cs
Show resolved
Hide resolved
…text to shared test between RDF and RDG.
captainsafia
approved these changes
Apr 25, 2023
Remove redundant JsonSerializerOptions.
eiriktsarpalis
approved these changes
Apr 25, 2023
Rename JsonTypeInfo extension method IsValid to ShouldUseWith.
|
OK, I have addressed all feedback. I'm going to merge this once it is green to make the 8.0-preview4 cutoff. |
ghost
added this to the
eerhardt
added a commit
to eerhardt/aspnetcore
that referenced
this pull request
Apr 26, 2023
This was missed in dotnet#47859 and is causing trimming/AOT warnings from generated code.
eerhardt
added a commit
that referenced
this pull request
Apr 26, 2023
This was missed in #47859 and is causing trimming/AOT warnings from generated code.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
This was missed in #47859 and is causing trimming/AOT warnings from generated code.
wtgodbe
pushed a commit
that referenced
this pull request
Apr 27, 2023
This was missed in #47859 and is causing trimming/AOT warnings from generated code. Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling GetTypeInfo with the object's runtime type doesn't work when using unspeakable types and using JSON source generation. There is no way to mark the unspeakable type (like a C# compiler implemented IAsyncEnumerable iterator) as JsonSerializable.
Instead, when the "declared type"'s JsonTypeInfo isn't compatible with the runtime type w.r.t. polymorphism, serialize the value "as object", letting System.Text.Json's serialization take over to serialize the value.
Fix #47548