Add suppression message to JSON serialization #47908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in dotnet#47859 and is causing trimming/AOT warnings from generated code.
eerhardt
requested review from
Tratcher,
BrennanConroy,
halter73 and
captainsafia
as code owners
ghost
added
the
captainsafia
approved these changes
Apr 26, 2023
halter73
approved these changes
Apr 26, 2023
|
Thanks! I plan to backport this to preview4 along with #47414. |
|
/backport to release/8.0-preview4 |
|
Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/8.0-preview4: https://github.com/dotnet/aspnetcore/actions/runs/4812381922 |
10 tasks
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #47859 and is causing trimming/AOT warnings from generated code.