-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment to gRPC template tests SkipOnAlpine attribute #46517
Conversation
Looks like they passed on the musl runs. |
@dotnet/aspnet-build Do PRs run tests on alpine? I don’t want to merge this and then break main build. |
@JamesNK That's why I mentioned musl above. It runs on an alpine container: |
Hmm, I think it's built there, but I don't think the template tests run there. Helix Alpine queue only runs on the main build: aspnetcore/eng/targets/Helix.Common.props Line 43 in 5bd03bb
How can I run here from a PR? Temporarily update Helix.Common.props to add the queue to PR? |
If by "main build" you mean You may want to rebase the branch first because |
This reverts commit 3cad473.
IMO that workaround is bogus. Installing the glibc compat package is a crutch and not a real solution. If we support Alpine (which we say we do https://github.com/dotnet/core/blob/main/release-notes/7.0/supported-os.md), we should be building a musl-compatible binary. This is analogous to saying we support ARM64, but requiring Rosetta 2 to run on a macOS M1 machine. |
Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
re: #46462 (comment)