Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to gRPC template tests SkipOnAlpine attribute #46517

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 8, 2023

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Feb 8, 2023
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 8, 2023
@adityamandaleeka
Copy link
Member

Looks like they passed on the musl runs.

@JamesNK
Copy link
Member Author

JamesNK commented Feb 8, 2023

@dotnet/aspnet-build Do PRs run tests on alpine? I don’t want to merge this and then break main build.

@adityamandaleeka
Copy link
Member

adityamandaleeka commented Feb 8, 2023

@JamesNK That's why I mentioned musl above. It runs on an alpine container:

Link to build log from this PR

@JamesNK
Copy link
Member Author

JamesNK commented Feb 8, 2023

Hmm, I think it's built there, but I don't think the template tests run there.

Helix Alpine queue only runs on the main build:

<HelixAvailableTargetQueue Include="$(HelixQueueAlpine314)" Platform="Linux" />

How can I run here from a PR? Temporarily update Helix.Common.props to add the queue to PR?

@dougbu
Copy link
Member

dougbu commented Feb 8, 2023

Hmm, I think it's built there, but I don't think the template tests run there.

Helix Alpine queue only runs on the main build:

<HelixAvailableTargetQueue Include="$(HelixQueueAlpine314)" Platform="Linux" />

How can I run here from a PR? Temporarily update Helix.Common.props to add the queue to PR?

If by "main build" you mean aspnetcore-helix-matrix, then updating Helix.Common.props could work. The alternative is to head over to the pipeline and click Run Pipeline, selecting this branch.

You may want to rebase the branch first because Run Pipeline won't auto-merge w/ 'main' the way CI builds do.

@JamesNK
Copy link
Member Author

JamesNK commented Feb 8, 2023

The templates still fail on Alpine:
image

The issue was closed because a workaround was provided, and we're not doing that on our machine. I'm going to change this PR to update the attribute description.

@JamesNK JamesNK changed the title Remove SkipOnAlpine from gRPC template tests Add comment to gRPC template tests SkipOnAlpine attribute Feb 8, 2023
@JamesNK JamesNK enabled auto-merge (squash) February 8, 2023 08:57
@JamesNK JamesNK merged commit 287d7ea into main Feb 8, 2023
@JamesNK JamesNK deleted the jamesnk/grpctemplates-alphine branch February 8, 2023 09:02
@ghost ghost added this to the 8.0-preview2 milestone Feb 8, 2023
@eerhardt
Copy link
Member

eerhardt commented Feb 8, 2023

a workaround was provided

IMO that workaround is bogus. Installing the glibc compat package is a crutch and not a real solution. If we support Alpine (which we say we do https://github.com/dotnet/core/blob/main/release-notes/7.0/supported-os.md), we should be building a musl-compatible binary. This is analogous to saying we support ARM64, but requiring Rosetta 2 to run on a macOS M1 machine.

@ghost
Copy link

ghost commented Feb 8, 2023

Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants