Add aot option to gRPC template #46462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
JamesNK
changed the title
JamesNK
removed
the
area-mvc
JamesNK
commented
Feb 6, 2023
src/ProjectTemplates/Web.ProjectTemplates/GrpcService-CSharp.csproj.in
Outdated
Show resolved
Hide resolved
|
Tested locally:
|
JamesNK
requested review from
davidfowl,
eerhardt,
halter73,
captainsafia and
mitchdenny
eerhardt
approved these changes
Feb 7, 2023
|
|
||
| [ConditionalFact(Skip = "Unskip when there are no more build or publish warnings for native AOT.")] | ||
| [SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)] | ||
| [SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] |
There was a problem hiding this comment.
The linked issue was closed 3 years ago. Is this "skip" really necessary?
There was a problem hiding this comment.
I'll investigate in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #45888