Skip to content

[release/7.0] Get template error codes from the right processes #44246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 29, 2022

Backport of #44032 to release/7.0

/cc @dougbu @Tratcher

  • tell-mode (test-only) change

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 29, 2022
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 29, 2022
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is one of the few visible differences between release/7.0 and main under src/ProjectTemplates. Since #44233 is seeing problems w/ the template tests, this backport may help.

@dougbu
Copy link
Contributor

dougbu commented Sep 29, 2022

/fyi @Tratcher @dotnet/aspnet-build

@dougbu dougbu enabled auto-merge (squash) September 29, 2022 05:02
@Tratcher
Copy link
Member

Tratcher commented Sep 29, 2022

@dougbu, this was not a functional improvement, only a diagnostic improvement to report the right error codes. I wouldn't expect any behavior difference.

@dougbu dougbu merged commit 149ef33 into release/7.0 Sep 29, 2022
@dougbu dougbu deleted the backport/pr-44032-to-release/7.0 branch September 29, 2022 06:04
@dougbu
Copy link
Contributor

dougbu commented Sep 29, 2022

I wouldn't expect any behavior difference.

We need better telemetry in release/7.0 and should be taking relevant test improvements back as a matter of course. In any case, template tests failed in #44233 and I'm hoping to get more information now this is merged.

@dougbu dougbu added this to the 7.0.0 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants