Skip to content

[release/7.0] Move to an RTM SDK #44233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Sep 28, 2022

No description provided.

@dougbu dougbu requested review from a team and wtgodbe as code owners September 28, 2022 21:29
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 28, 2022
@wtgodbe wtgodbe self-requested a review September 28, 2022 21:46
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess 7.0.100-rtm.22477.16 is from the internal branch, 7.0.100-rtm.22478.12 is the latest I could find from a build of release/7.0.1xx

@dougbu
Copy link
Contributor Author

dougbu commented Sep 28, 2022

I guess 7.0.100-rtm.22477.16 is from the internal branch

It's the version https://aka.ms/dotnet/7.0.1xx/daily/productCommit-win-x64.txt shows. I asked @marcpopMSFT in FR whether we should prefer that or the version from https://github.com/dotnet/installer. Also asking FR people how previous problems like this have been resolved.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 28, 2022

It's the version https://aka.ms/dotnet/7.0.1xx/daily/productCommit-win-x64.txt shows. I asked @marcpopMSFT in FR whether we should prefer that or the version from https://github.com/dotnet/installer. Also asking FR people how previous problems like this have been resolved.

That looks like a bug in the table, here's the build that produced it (note it's of internal/release/7.0.1xx): https://dev.azure.com/dnceng/internal/_build/results?buildId=2005514&view=results

@dougbu
Copy link
Contributor Author

dougbu commented Sep 28, 2022

https://aka.ms/dotnet/7.0.1xx/daily/productCommit-win-x64.txt better not refer to internal builds because that's a public file ☹️ In other words, I'm hoping there's an issue somewhere other than in pushing that version of the .txt file.

@dougbu
Copy link
Contributor Author

dougbu commented Sep 28, 2022

Think I figured it out. I took the version from the SDK line in productCommit-win-x64.txt instead of the installer line.

Note we normally build and make daily builds public from the internal/… branches. It's only internal & secure builds that won't touch the dotnet7 or dotnet7-transport feeds. Right @mmitche

As far as I can see, nothing is wrong w/ either dotnet/installer or the productCommit-win-x64.txt file. @marcpopMSFT you can stand down 😁

@mmitche
Copy link
Member

mmitche commented Sep 28, 2022

Think I figured it out. I took the version from the SDK line in productCommit-win-x64.txt instead of the installer line.

Note we normally build and make daily builds public from the internal/… branches. It's only internal & secure builds that won't touch the dotnet7 or dotnet7-transport feeds. Right @mmitche

As far as I can see, nothing is wrong w/ either dotnet/installer or the productCommit-win-x64.txt file. @marcpopMSFT you can stand down 😁

The internal/* branches are never public. Only the release/* branches are.

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 28, 2022
@dougbu
Copy link
Contributor Author

dougbu commented Sep 29, 2022

Most template tests failing w/

Failure to uninstall
2022-09-28T23:00:37.0513990Z   Error Message:
2022-09-28T23:00:37.0514160Z    System.InvalidOperationException : Failed to uninstall previous templates. The template 'web' could still be found.
2022-09-28T23:00:37.0514210Z   Stack Trace:
2022-09-28T23:00:37.0514330Z      at Templates.Test.Helpers.TemplatePackageInstaller.VerifyCannotFindTemplateAsync(ITestOutputHelper output, String templateName) in /_/src/ProjectTemplates/Shared/TemplatePackageInstaller.cs:line 144
Failure to install
2022-09-28T23:00:37.0518130Z  | [0.029s] Templates.Mvc.Test.RazorPagesTemplateTest Information: ==> /private/tmp/helix/working/B0BD097A/p/dotnet-cli/dotnet new "web" --debug:disable-sdk-templates --debug:custom-hive "/private/tmp/helix/working/B0BD097A/w/AA620921/e/Hives/.templateEngine" [/private/tmp/helix/working/B0BD097A/w/AA620921/e/]
2022-09-28T23:00:37.0518200Z  | [0.355s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] No templates or subcommands found matching: 'web'.
2022-09-28T23:00:37.0518240Z  | [0.361s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] 
2022-09-28T23:00:37.0518280Z  | [0.362s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] To list installed templates similar to 'web', run:
2022-09-28T23:00:37.0518330Z  | [0.363s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR]    dotnet new list web
2022-09-28T23:00:37.0518510Z  | [0.363s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] To search for the templates on NuGet.org, run:
2022-09-28T23:00:37.0518550Z  | [0.363s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR]    dotnet new search web
2022-09-28T23:00:37.0518590Z  | [0.363s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] 
2022-09-28T23:00:37.0518620Z  | [0.365s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] 
2022-09-28T23:00:37.0518660Z  | [0.365s] Templates.Mvc.Test.RazorPagesTemplateTest Information: [ERROR] For details on the exit code, refer to https://aka.ms/templating-exit-codes#103

I'll check for differences in the relevant files between release/7.0 and main.

@dougbu
Copy link
Contributor Author

dougbu commented Sep 29, 2022

Will retry after #44246 is in; that may help here.

@dougbu
Copy link
Contributor Author

dougbu commented Sep 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dougbu dougbu force-pushed the dougbu/latest.sdk/7.0 branch from 92d2071 to a5793ba Compare September 29, 2022 23:09
@dougbu dougbu merged commit d82e861 into dotnet:release/7.0 Sep 30, 2022
@dougbu dougbu deleted the dougbu/latest.sdk/7.0 branch September 30, 2022 01:30
@dougbu
Copy link
Contributor Author

dougbu commented Sep 30, 2022

@wtgodbe and @BrennanConroy thanks very much for your help w/ this❕

@dougbu dougbu added this to the 7.0.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants