[release/6.0] Use full suffixed version for DepProviderKey in installers #39035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
added
the
tell-mode
ghost
added this to the
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
joeloff
reviewed
Dec 14, 2021
| <TargetingPackInstallerBaseName>aspnetcore-targeting-pack</TargetingPackInstallerBaseName> | ||
|
|
||
| <!-- This is used to produce targeting pack installers/packages once per major.minor. --> | ||
| <!-- This is used to produce targeting pack installers/packages once per major.minor, or when we need to service it (e.g. 6.0.2) --> |
Member
There was a problem hiding this comment.
This is to address the package code issue with the repair scenario in the short term, correct?
Contributor
|
@TanayParikh this is still failing on macOS as if you did not change the |
Contributor
This source nor the target branches have the macos timeout related fixes from yesterday.
Backport discussion here: #39032 |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
dougbu
approved these changes
Dec 17, 2021
Pilchie
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 port of #39022.
Fixes a bug where preview, RC, and RTM targeting pack installers all have the same Dependency Provider Key due to using only Major.Minor.Patch as their version string. Also turns on build of the targeting pack for 6.0.2.