Skip to content

Commit 21bdd57

Browse files
authored
[release/6.0] Use full suffixed version for DepProviderKey in installers (#39035)
* Use full suffixed version for DepProviderKey in installers (#39022) * Build targeting pack * Fixup
1 parent 08efc56 commit 21bdd57

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Directory.Build.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,9 @@
141141
<RuntimeInstallerBaseName>aspnetcore-runtime</RuntimeInstallerBaseName>
142142
<TargetingPackInstallerBaseName>aspnetcore-targeting-pack</TargetingPackInstallerBaseName>
143143

144-
<!-- This is used to produce targeting pack installers/packages once per major.minor. -->
144+
<!-- This is used to produce targeting pack installers/packages once per major.minor, or when we need to service it (e.g. 6.0.2) -->
145145
<IsTargetingPackBuilding
146-
Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '0' ">false</IsTargetingPackBuilding>
146+
Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '2' ">false</IsTargetingPackBuilding>
147147
<IsTargetingPackBuilding Condition=" '$(IsTargetingPackBuilding)' == '' ">true</IsTargetingPackBuilding>
148148

149149
<!--

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
-->
3030
<TargetingPackVersionPrefix>$(VersionPrefix)</TargetingPackVersionPrefix>
3131
<!-- Targeting packs do not produce patch versions in servicing builds. No API changes are allowed in patches. -->
32-
<TargetingPackVersionPrefix Condition="'$(IsTargetingPackBuilding)' != 'true'">$(AspNetCoreMajorMinorVersion).0</TargetingPackVersionPrefix>
32+
<TargetingPackVersionPrefix Condition="'$(IsTargetingPackBuilding)' != 'true'">$(AspNetCoreMajorMinorVersion).2</TargetingPackVersionPrefix>
3333
<ExperimentalVersionPrefix>0.3.$(AspNetCorePatchVersion)</ExperimentalVersionPrefix>
3434
<!-- ANCM versioning is intentionally 10 + AspNetCoreMajorVersion because earlier versions of ANCM shipped as 8.x. -->
3535
<AspNetCoreModuleVersionMajor>$([MSBuild]::Add(10, $(AspNetCoreMajorVersion)))</AspNetCoreModuleVersionMajor>

src/Installers/Windows/Wix.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
<PropertyGroup Condition="'$(OutputType)' == 'package'">
2424
<InstallDir>$(ProductName)</InstallDir>
25-
<DepProviderKey>Microsoft.$(ProductNameShort)_$(Platform)_$(Lang),v$(PackageVersion)</DepProviderKey>
25+
<DepProviderKey>Microsoft.$(ProductNameShort)_$(Platform)_$(Lang),v$(_GeneratedPackageVersion)</DepProviderKey>
2626
<DefineConstants>$(DefineConstants);DepProviderKey=$(DepProviderKey)</DefineConstants>
2727
</PropertyGroup>
2828

0 commit comments

Comments
 (0)