Fix components-e2e Pipeline
#38704
Merged
Fix components-e2e Pipeline
#38704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged.
ghost
added
the
area-infrastructure
Contributor
|
Out of curiosity, where do quarantined Blazor e2e tests run? |
Contributor
Author
They're now being run as part of a new step of the |
pranavkm
approved these changes
Nov 29, 2021
dougbu
reviewed
Nov 29, 2021
dougbu
reviewed
Nov 29, 2021
dougbu
reviewed
Nov 29, 2021
dougbu
suggested changes
Nov 30, 2021
dougbu
reviewed
Nov 30, 2021
- I pointed to an `xUnit` example, sorry
Contributor
Author
|
Thanks Doug, applied your suggestions (and replaced |
dougbu
reviewed
Nov 30, 2021
Contributor
|
Looks like copying from Arcade didn't help you: |
Contributor
|
|
dougbu
approved these changes
Nov 30, 2021
| - script: .dotnet/dotnet test ./src/Components/test/E2ETest -c $(BuildConfiguration) --no-build --filter 'Quarantined!=true|Quarantined=false' | ||
| --logger:"trx%3BLogFileName=Microsoft.AspNetCore.Components.E2ETests.trx" | ||
| --logger:"html%3BLogFileName=Microsoft.AspNetCore.Components.E2ETests.html" | ||
| --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(BuildConfiguration)/Unquarantined |
Contributor
There was a problem hiding this comment.
nit: We don't include /Unquarantined elsewhere but I guess it doesn't matter much if the artifacts are a bit different from those we see in other non-quarantined pipelines.
Contributor
Author
|
🎉 |
4 tasks
Contributor
Author
10 tasks
TanayParikh
added a commit
that referenced
this pull request
Dec 3, 2021
* Fix `components-e2e` Pipeline Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged. * Update components-e2e-tests.yml * PR Feedback * Update components-e2e-tests.yml - I pointed to an `xUnit` example, sorry * PR Feedback * PR Feedback * Update artifacts dir Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
wtgodbe
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Quarantine CanAddAndDisposeRootComponents (#38693) * Fix `components-e2e` Pipeline (#38704) * Fix `components-e2e` Pipeline Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged. * Update components-e2e-tests.yml * PR Feedback * Update components-e2e-tests.yml - I pointed to an `xUnit` example, sorry * PR Feedback * PR Feedback * Update artifacts dir Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the
QuarantinedTestattribute.Using the
Quarantinedtrait defined here:aspnetcore/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs
Line 18 in ba18614
Extension of #38693 which got auto-merged.